tree dbbe66c763e4fd486d13703617ba092e7e7437e6
parent 6b7d4c55586a849aa8313282d79432917eade3bf
author Kevin Wolf <kwolf@redhat.com> 1395835564 +0100
committer Stefan Hajnoczi <stefanha@redhat.com> 1396358555 +0200

qcow2: Fix NULL dereference in qcow2_open() error path (CVE-2014-0146)

The qcow2 code assumes that s->snapshots is non-NULL if s->nb_snapshots
!= 0. By having the initialisation of both fields separated in
qcow2_open(), any error occuring in between would cause the error path
to dereference NULL in qcow2_free_snapshots() if the image had any
snapshots.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>