)]}'
{
  "commit": "1084feddc6a677cdfdde56936bfb97cf32cc4dee",
  "tree": "4c726da0e9357961e64fb1aec9bd2ee6bb66c7cc",
  "parents": [
    "503d86dd66625b4bed9484bca71db1678c730dc9"
  ],
  "author": {
    "name": "Eric Auger",
    "email": "eric.auger@redhat.com",
    "time": "Tue Jul 18 20:21:36 2023 +0200"
  },
  "committer": {
    "name": "Michael S. Tsirkin",
    "email": "mst@redhat.com",
    "time": "Thu Aug 03 16:06:49 2023 -0400"
  },
  "message": "virtio-iommu: Standardize granule extraction and formatting\n\nAt several locations we compute the granule from the config\npage_size_mask using ctz() and then format it in traces using\nBIT(). As the page_size_mask is 64b we should use ctz64 and\nBIT_ULL() for formatting. We failed to be consistent.\n\nNote the page_size_mask is garanteed to be non null. The spec\nmandates the device to set at least one bit, so ctz64 cannot\nreturn 64. This is garanteed by the fact the device\ninitializes the page_size_mask to qemu_target_page_mask()\nand then the page_size_mask is further constrained by\nvirtio_iommu_set_page_size_mask() callback which can\u0027t\nresult in a new mask being null. So if Coverity complains\nround those ctz64/BIT_ULL with CID 1517772 this is a false\npositive\n\nSigned-off-by: Eric Auger \u003ceric.auger@redhat.com\u003e\nFixes: 94df5b2180 (\"virtio-iommu: Fix 64kB host page size VFIO device assignment\")\nMessage-Id: \u003c20230718182136.40096-1-eric.auger@redhat.com\u003e\nReviewed-by: Michael S. Tsirkin \u003cmst@redhat.com\u003e\nSigned-off-by: Michael S. Tsirkin \u003cmst@redhat.com\u003e\nReviewed-by: Jean-Philippe Brucker \u003cjean-philippe@linaro.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4dcf1d5c62f53a82eb7c0c49401d4e9497768a27",
      "old_mode": 33188,
      "old_path": "hw/virtio/virtio-iommu.c",
      "new_id": "be51635895ce88cb69ec987a5c7d3fa33a703c9e",
      "new_mode": 33188,
      "new_path": "hw/virtio/virtio-iommu.c"
    }
  ]
}
