Google Git
Sign in
qemu / qemu / 04b3fb39c815e6de67c5003e610d1cdecc911980
commit04b3fb39c815e6de67c5003e610d1cdecc911980[log] [tgz]
authorStefan Hajnoczi <stefanha@redhat.com>Wed Jun 17 14:21:57 2020 +0100
committerStefan Hajnoczi <stefanha@redhat.com>Tue Jun 23 15:46:08 2020 +0100
treea22cf62646ba060d29a58e8ab1bee6112ba41265
parentd38253cf8b44e3b94a5b327d014ab035ae1126ed [diff]
block/nvme: don't access CQE after moving cq.head

Do not access a CQE after incrementing q->cq.head and releasing q->lock.
It is unlikely that this causes problems in practice but it's a latent
bug.

The reason why it should be safe at the moment is that completion
processing is not re-entrant and the CQ doorbell isn't written until the
end of nvme_process_completion().

Make this change now because QEMU expects completion processing to be
re-entrant and later patches will do that.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Sergio Lopez <slp@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200617132201.1832152-4-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
1 file changed
tree: a22cf62646ba060d29a58e8ab1bee6112ba41265
  1. .github/
  2. .gitlab-ci.d/
  3. accel/
  4. audio/
  5. authz/
  6. backends/
  7. block/
  8. bsd-user/
  9. chardev/
  10. contrib/
  11. crypto/
  12. default-configs/
  13. disas/
  14. docs/
  15. dump/
  16. fpu/
  17. fsdev/
  18. gdb-xml/
  19. hw/
  20. include/
  21. io/
  22. libdecnumber/
  23. linux-headers/
  24. linux-user/
  25. migration/
  26. monitor/
  27. nbd/
  28. net/
  29. pc-bios/
  30. plugins/
  31. po/
  32. python/
  33. qapi/
  34. qga/
  35. qobject/
  36. qom/
  37. replay/
  38. roms/
  39. scripts/
  40. scsi/
  41. softmmu/
  42. storage-daemon/
  43. stubs/
  44. target/
  45. tcg/
  46. tests/
  47. tools/
  48. trace/
  49. ui/
  50. util/
  51. capstone
  52. dtc
  53. slirp
  54. .cirrus.yml
  55. .dir-locals.el
  56. .editorconfig
  57. .exrc
  58. .gdbinit
  59. .gitignore
  60. .gitlab-ci.yml
  61. .gitmodules
  62. .gitpublish
  63. .mailmap
  64. .patchew.yml
  65. .readthedocs.yml
  66. .shippable.yml
  67. .travis.yml
  68. arch_init.c
  69. balloon.c
  70. block.c
  71. blockdev-nbd.c
  72. blockdev.c
  73. blockjob.c
  74. bootdevice.c
  75. Changelog
  76. CODING_STYLE.rst
  77. configure
  78. COPYING
  79. COPYING.LIB
  80. cpus-common.c
  81. cpus.c
  82. device_tree.c
  83. disas.c
  84. dma-helpers.c
  85. exec-vary.c
  86. exec.c
  87. gdbstub.c
  88. gitdm.config
  89. hmp-commands-info.hx
  90. hmp-commands.hx
  91. ioport.c
  92. iothread.c
  93. job-qmp.c
  94. job.c
  95. Kconfig.host
  96. LICENSE
  97. MAINTAINERS
  98. Makefile
  99. Makefile.objs
  100. Makefile.target
  101. memory.c
  102. memory_ldst.inc.c
  103. memory_mapping.c
  104. module-common.c
  105. os-posix.c
  106. os-win32.c
  107. qdev-monitor.c
  108. qemu-bridge-helper.c
  109. qemu-edid.c
  110. qemu-img-cmds.hx
  111. qemu-img.c
  112. qemu-io-cmds.c
  113. qemu-io.c
  114. qemu-keymap.c
  115. qemu-nbd.c
  116. qemu-options-wrapper.h
  117. qemu-options.h
  118. qemu-options.hx
  119. qemu-seccomp.c
  120. qemu-storage-daemon.c
  121. qemu.nsi
  122. qemu.sasl
  123. qtest.c
  124. README.rst
  125. replication.c
  126. replication.h
  127. rules.mak
  128. thunk.c
  129. tpm.c
  130. trace-events
  131. VERSION
  132. version.rc