commit 012aef073461fd24a901d7a8742532093b7f6ae5
author Markus Armbruster <armbru@redhat.com> Wed Aug 26 14:02:53 2015 +0200
committer Michael Tokarev <mjt@tls.msk.ru> Fri Sep 11 10:21:38 2015 +0300
tree 4ee28d5cedea44f2af2b5b3a7fe482d9e80a3fad
parent ef1e1e0782e99c9dcf2b35e5310cdd8ca9211374

maint: avoid useless "if (foo) free(foo)" pattern

My Coccinelle semantic patch finds a few more, because it also fixes up
the equally pointless conditional

    if (foo) {
        free(foo);
        foo = NULL;
    }

Result (feel free to squash it into your patch):

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

hw/net/rtl8139.c

diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
index 2040618..b0d6c40 100644
--- a/hw/net/rtl8139.c
+++ b/hw/net/rtl8139.c
@@ -3391,10 +3391,8 @@
 {
     RTL8139State *s = RTL8139(dev);
 
-    if (s->cplus_txbuffer) {
-        g_free(s->cplus_txbuffer);
-        s->cplus_txbuffer = NULL;
-    }
+    g_free(s->cplus_txbuffer);
+    s->cplus_txbuffer = NULL;
     timer_del(s->timer);
     timer_free(s->timer);
     qemu_del_nic(s->nic);