tree 624bfbc2793f4d7453b9a4abf069bb3c4394a127
parent 80e1d28b042def24b7325f84247dadf94c507bfd
author Sam James <sam@gentoo.org> 1710283064 +0000
committer Eli Schwartz <eschwartz93@gmail.com> 1711601545 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQJKBAABCAA0FiEEYEETBMCdNmKDQO7/zrFn77VyK9YFAmYE94kWHGVzY2h3YXJ0
 ejkzQGdtYWlsLmNvbQAKCRDOsWfvtXIr1uGDD/9LfSkF19as+rfwK6ANURGh2E2m
 tUqYAujPqGOgagGp+KmFCc+tbIZVA2tKmzH/LJgyMlQXis5mXX8zymBJlF6dw6Da
 uTwVpbFOgoNoYOv/LXQ50LuBwSIFTtlL+Vo+cKYa+VqUB9varx0qCfUPuDkojLhp
 ioHxL1N3nskoew1cSEMHOXKosSHKs8OWT92k5JfZBHHm7GfNVgfIlCosTponmWhx
 zvk+v/tFdqChOGdSJkPTY6bDm/lB5Wv6E4tL9Vuy1SWFgFU0/jaeN69XVN4EMLg9
 z7Q8ig0NiZCbnLhyWPbimXWmX9VymJ8cuwR8Kxsy1wiTU/W9Tm4eKhlcMz4nE/rF
 vZLQjQTxqbrJCIIS8dcwBt+m6BQinUoO/M+nLkURp7qUAr9jlS1tKb7eagvOpMiz
 GHyRcWBSOwadaW/cbsmYW4T5q9IigiYfjltTKCIjDGKPwQIwEFyl4a0om4DwmwHl
 a1+SDCldi/bi7ioveYouDo216mT4+5DamZhuViCfLFoPdDCqZeH1szSi4QQmeLLl
 fLYQ7ER2OLWgMsngRAfBzLnPskyWFGSeReh0owRpHLviTzL6/XnosqMwYdDIZItS
 A+dDQJ5Jyt75q11mlS7jLm/x40btyBxK8L/pl8lX9JOoU1ZnwYoJxi8cxBpIwX0h
 oqYREGA9MWA2zu1iXw==
 =pCq3
 -----END PGP SIGNATURE-----

compilers: cpp: relax assertion level for libc++

Followup to 90098473d51e6f059e775f1833b0a2ea91c8f8f9.

I changed my mind on this a few times. libcxx's documentation describes [0]
the hardening modes as:
"""
1) Unchecked mode/none, which disables all hardening checks.
2) Fast mode, which contains a set of security-critical checks that can be done
   with relatively little overhead in constant time and are intended to be used
   in production. We recommend most projects adopt this.
3) Extensive mode, which contains all the checks from fast mode and some additional
   checks for undefined behavior that incur relatively little overhead but aren’t
   security-critical. Production builds requiring a broader set of checks than fast
   mode should consider enabling extensive mode. The additional rigour impacts performance
   more than fast mode: we recommend benchmarking to determine if that is acceptable
   for your program.
4) Debug mode, which enables all the available checks in the library, including
   internal assertions, some of which might be very expensive. This mode is
   intended to be used for testing, not in production.
"""

We chose 3) before because it felt like a better fit for what we're trying
to do and the most equivalent option to libstdc++'s _GLIBCXX_ASSERTIONS, but on
reflection, maybe we're better off picking a default with less overhead and
more importantly guarantees constant time checks.

[0] https://libcxx.llvm.org/Hardening.html#using-hardening-modes

Bug: https://github.com/mesonbuild/meson/issues/12962
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>