Google Git
Sign in
qemu / libslirp / 3ea1a72ad61865fac3134686d5f4c6b4a17b2a91
commit3ea1a72ad61865fac3134686d5f4c6b4a17b2a91[log] [tgz]
authorPeter Maydell <peter.maydell@linaro.org>Sun Jul 09 18:54:22 2017 +0100
committerSamuel Thibault <samuel.thibault@ens-lyon.org>Sat Jul 15 14:28:25 2017 +0200
tree7181be361516b1ea31a4d5fa13a50b41fb87e097
parentc0870d703b1c5a7bb6c573c585957751b3971f4e [diff]
slirp: fork_exec(): Don't close() a negative number in fork_exec()

In a fork_exec() error path we try to closesocket(s) when s might
be a negative number because the thing that failed was the
qemu_socket() call. Add a guard so we don't do this.

(Spotted by Coverity: CID 1005727 issue 1 of 2.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
1 file changed
tree: 7181be361516b1ea31a4d5fa13a50b41fb87e097
  1. arp_table.c
  2. bootp.c
  3. bootp.h
  4. cksum.c
  5. COPYRIGHT
  6. debug.h
  7. dhcpv6.c
  8. dhcpv6.h
  9. dnssearch.c
  10. if.c
  11. if.h
  12. ip.h
  13. ip6.h
  14. ip6_icmp.c
  15. ip6_icmp.h
  16. ip6_input.c
  17. ip6_output.c
  18. ip_icmp.c
  19. ip_icmp.h
  20. ip_input.c
  21. ip_output.c
  22. libslirp.h
  23. main.h
  24. Makefile.objs
  25. mbuf.c
  26. mbuf.h
  27. misc.c
  28. misc.h
  29. ncsi-pkt.h
  30. ncsi.c
  31. ndp_table.c
  32. sbuf.c
  33. sbuf.h
  34. slirp.c
  35. slirp.h
  36. slirp_config.h
  37. socket.c
  38. socket.h
  39. tcp.h
  40. tcp_input.c
  41. tcp_output.c
  42. tcp_subr.c
  43. tcp_timer.c
  44. tcp_timer.h
  45. tcp_var.h
  46. tcpip.h
  47. tftp.c
  48. tftp.h
  49. udp.c
  50. udp.h
  51. udp6.c