ncsi: bounds-check OEM command bodies before dereferencing them

ncsi_input() validates pkt_len only against the NC-SI common header
(sizeof(struct ncsi_pkt_hdr) = 16) -- the check added for CVE-2020-29129.
The OEM command dispatch, added afterwards, reads further into the frame
with no additional length check:

  * ncsi_rsp_handler_oem() reads cmd->mfr_id at NC-SI payload offset 16
    (frame offset ETH_HLEN + 16 = 30) and reflects it into the response
    (rsp->mfr_id = cmd->mfr_id) before the mfr_id match test -- so a guest
    OEM frame of 30..33 bytes causes an out-of-bounds read whose bytes are
    sent back to the guest (info leak). Unconditional.

  * when the host is configured as Mellanox (mfr_id == 0x8119),
    ncsi_rsp_handler_oem_mlx() then reads cmd_rev/cmd/param/optional from
    cmd->data (payload offset 20, frame offset 34) -- a guest frame of
    34..37 bytes reads out of bounds there too.

Both are guest-triggerable out-of-bounds reads of the raw RX buffer and a
residual of CVE-2020-29129 (which covered only the common header). They
were found by fuzzing the NC-SI path (which upstream does not fuzz) with a
guard-page allocator: 30/31/32-byte frames fault at ncsi.c:136, a 37-byte
frame faults at ncsi.c:107.

Reject OEM frames too short to contain the fields the handlers read.

  sizeof(struct ncsi_cmd_oem_pkt)      == 20  -> generic OEM min 34 bytes
  + sizeof(struct ncsi_rsp_oem_mlx_pkt) == 4  -> Mellanox     min 38 bytes
1 file changed
tree: 1c537bf5b65b64abc206c633a58c5ccf1f899d8d
  1. build-aux/
  2. fuzzing/
  3. src/
  4. test/
  5. .clang-format
  6. .gitignore
  7. .gitlab-ci.yml
  8. .gitpublish
  9. CHANGELOG.md
  10. COPYRIGHT
  11. LICENSE
  12. meson.build
  13. meson_options.txt
  14. README.md
README.md

libslirp

libslirp is a user-mode networking library used by virtual machines, containers or various tools.

Getting Started

Prerequisites

A C compiler, meson and glib2 development libraries.

(see also .gitlab-ci.yml DEPS variable for the list of dependencies on Fedora)

Building

You may build and install the shared library with meson:

meson build
ninja -C build install

And configure QEMU with --enable-slirp=system to link against it.

(QEMU may build with the submodule static library using --enable-slirp=git)

Testing

Unfortunately, there are no automated tests available.

You may run QEMU -net user linked with your development version.

Contributing

Feel free to open issues on the project issues page.

You may clone the gitlab project and create a merge request.

Contributing with gitlab allows gitlab workflow, tracking issues, running CI etc.

Alternatively, you may send patches to slirp@lists.freedesktop.org mailing list.

Security reports can be sent to samuel.thibault@ens-lyon.org with pgp key 900CB024B67931D40F82304BD0178C767D069EE6 (it can be found in the debian keyring for instance)

Debugging

To make slirp emit debugging prints, one can use for instance:

export G_MESSAGES_DEBUG=Slirp
export SLIRP_DEBUG=call

SLIRP_DEBUG can contain a colons/spaces/commas-separated list of call, misc, error, tftp, verbose_call

Versioning

We intend to use libtool's versioning for the shared libraries and use SemVer for project versions.

For the versions available, see the tags on this repository.

License

See the COPYRIGHT file for details.