tree dbdd17ee66f496fa89dbf8ae0854b6031474b9ed
parent 3c83843e111ece30d3dfb5143d5e6aed6164d587
author Michael Brown <mcb30@ipxe.org> 1676320842 +0000
committer Michael Brown <mcb30@ipxe.org> 1676324163 +0000

[image] Check delimiters when parsing command-line key-value arguments

The Linux kernel bzImage image format and the CPIO archive constructor
will parse the image command line for certain arguments of the form
"key=value".  This parsing is currently implemented using strstr() in
a way that can cause a false positive suffix match.  For example, a
command line containing "highmem=<n>" would erroneously be treated as
containing a value for "mem=<n>".

Fix by centralising the logic used for parsing such arguments, and
including a check that the argument immediately follows a whitespace
delimiter (or is at the start of the string).

Signed-off-by: Michael Brown <mcb30@ipxe.org>