tree 9e4c731196cfb010aa28a29616fe9b85301c7743
parent b240eab03530f063ef5438497d70a731b19a201e
author Mike Beaton <mjsbeaton@gmail.com> 1694057682 +0800
committer Liming Gao <gaoliming@byosoft.com.cn> 1694392981 +0800

MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

The immediately preceding call, GetBestLanguage, plus the implementation of
HiiGetString, which is called immediately afterwards, make it clear that
BestLanguage is a null-terminated ASCII string, and not just a five byte,
non-null terminated buffer.

Therefore AsciiStrLen is one byte too short, meaning that whether the space
allocated is really sufficient and whether the resultant string is really
null-terminated becomes implementation-dependent. Rather than switching to
AsciiStrSize, we use an explicitly compile-time string length calculation
(both compile-time and run-time approaches are currently used elsewhere in
the codebase for copying static strings).

Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>