tree 98fcb46e669e220cce63b42db3f21a6ac170bfd6
parent 9cceabea1ee09ae0864d365b7b3cc89a01b1287c
author David Gibson <david@gibson.dropbear.id.au> 1677499889 +1100
committer David Gibson <david@gibson.dropbear.id.au> 1677653247 +1100

Make build_property() xstrdup its name argument

The name field of 'struct property' was really always supposed to be a
malloc()ed string, that is owned by the structure.  To avoid an extra
strdup() for strings coming up from the lexer, build_property() and
build_property_delete() expect to take such an already malloc()ed string,
which means it's not correct to pass it a static string literal.

That's a pretty non-obvious constraint, so a bunch of incorrect uses have
crept in.  Really, avoiding the extra dup from the lexer isn't a big enough
benefit for this demonstrably dangerous interface.  So change it to do the
xstrdup() itself, removing the burden from callers.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>