Google Git
Sign in
qemu / dtc / 9cceabea1ee09ae0864d365b7b3cc89a01b1287c
commit9cceabea1ee09ae0864d365b7b3cc89a01b1287c[log] [tgz]
authorMatt Ranostay <matt.ranostay@konsulko.com>Tue Feb 28 18:33:21 2023 +0800
committerDavid Gibson <david@gibson.dropbear.id.au>Wed Mar 01 16:08:28 2023 +1100
treef997044835a1b199fa05a0b654452b196a8dd5d6
parent0d56145938fe5299c7a4fe0342fe8ba80698d564 [diff]
checks: correct I2C 10-bit address check

Currently if there is a valid 10-bit address the following warning is
always displayed due to the 7-bit check failing due to reg > 0x7f

"I2C address must be less than 7-bits, got "0x800000a6". Set I2C_TEN_BIT_ADDRESS for 10 bit addresses or fix the property"

Fix this issue by checking if a 10-bit address is expected, and is valid in separate if statements.

Fixes: 8259d59f ("checks: Improve i2c reg property checking")
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
1 file changed
tree: f997044835a1b199fa05a0b654452b196a8dd5d6
  1. Documentation/
  2. libfdt/
  3. pylibfdt/
  4. scripts/
  5. tests/
  6. .cirrus.yml
  7. .editorconfig
  8. .gitignore
  9. .travis.yml
  10. BSD-2-Clause
  11. checks.c
  12. CONTRIBUTING.md
  13. convert-dtsv0-lexer.l
  14. data.c
  15. dtc-lexer.l
  16. dtc-parser.y
  17. dtc.c
  18. dtc.h
  19. dtdiff
  20. fdtdump.c
  21. fdtget.c
  22. fdtoverlay.c
  23. fdtput.c
  24. flattree.c
  25. fstree.c
  26. GPL
  27. livetree.c
  28. Makefile
  29. Makefile.convert-dtsv0
  30. Makefile.dtc
  31. Makefile.utils
  32. MANIFEST.in
  33. meson.build
  34. meson_options.txt
  35. README.license
  36. README.md
  37. setup.py
  38. srcpos.c
  39. srcpos.h
  40. TODO
  41. treesource.c
  42. util.c
  43. util.h
  44. version_gen.h.in
  45. yamltree.c
README.md

Device Tree Compiler and libfdt

The source tree contains the Device Tree Compiler (dtc) toolchain for working with device tree source and binary files and also libfdt, a utility library for reading and manipulating the binary format.

dtc and libfdt are maintained by:

Python library

A Python library wrapping libfdt is also available. To build this you will need to install swig and Python development files. On Debian distributions:

$ sudo apt-get install swig python3-dev

The library provides an Fdt class which you can use like this:

$ PYTHONPATH=../pylibfdt python3
>>> import libfdt
>>> fdt = libfdt.Fdt(open('test_tree1.dtb', mode='rb').read())
>>> node = fdt.path_offset('/subnode@1')
>>> print(node)
124
>>> prop_offset = fdt.first_property_offset(node)
>>> prop = fdt.get_property_by_offset(prop_offset)
>>> print('%s=%s' % (prop.name, prop.as_str()))
compatible=subnode1
>>> node2 = fdt.path_offset('/')
>>> print(fdt.getprop(node2, 'compatible').as_str())
test_tree1

You will find tests in tests/pylibfdt_tests.py showing how to use each method. Help is available using the Python help command, e.g.:

$ cd pylibfdt
$ python3 -c "import libfdt; help(libfdt)"

If you add new features, please check code coverage:

$ sudo apt-get install python3-coverage
$ cd tests
# It's just 'coverage' on most other distributions
$ python3-coverage run pylibfdt_tests.py
$ python3-coverage html
# Open 'htmlcov/index.html' in your browser

The library can be installed with pip from a local source tree:

$ pip install . [--user|--prefix=/path/to/install_dir]

Or directly from a remote git repo:

$ pip install git+git://git.kernel.org/pub/scm/utils/dtc/dtc.git@main

The install depends on libfdt shared library being installed on the host system first. Generally, using --user or --prefix is not necessary and pip will use the default location for the Python installation which varies if the user is root or not.

You can also install everything via make if you like, but pip is recommended.

To install both libfdt and pylibfdt you can use:

$ make install [PREFIX=/path/to/install_dir]

To disable building the python library, even if swig and Python are available, use:

$ make NO_PYTHON=1

More work remains to support all of libfdt, including access to numeric values.

Mailing lists